Martin Sivák has posted comments on this change. Change subject: Support ioTune values >2^31 in getStats over xml-rpc ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30215/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2849: # with numbers bigger than int32_t Line 2850: for ioTune in decStats["ioTune"]: Line 2851: ioTune["ioTune"] = dict((k, utils.convertToStr(v)) for k, v Line 2852: in ioTune["ioTune"].iteritems()) Line 2853: stats[var] = decStats[var] > OK, but why not fix this much earlier, in the sampling thread for example? I do not want the data to be string at all, but we have to workaround xml-rpc (and jsonrpc engine side) :( Also if you look at the next two lines you will see that we fix other data here as well.. Line 2854: elif type(decStats[var]) is not dict: Line 2855: stats[var] = utils.convertToStr(decStats[var]) Line 2856: elif var in ('network', 'balloonInfo', 'vmJobs', Line 2857: 'vNodeRuntimeInfo'): -- To view, visit http://gerrit.ovirt.org/30215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5005d7fdc5397df2480fa8d0c15b003a52e8626 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
