Yaniv Bronhaim has submitted this change and it was merged.

Change subject: core: GET requests - use Range header
......................................................................


core: GET requests - use Range header

This patch replaces the use of the custom Size header with use of http
Range header.
(http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35)
Note that the use is similar to the use that was done with the Size header.
The motivation is to use the standard http header (instead of supporting a
custom header) and not to fully comply with the spec (as there are existing
gaps).

After this change the Range header is mandatory to issue a get request for an
image and support ranges between zero and specified last byte position.

Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1037500
Signed-off-by: Liron Aravot <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/28465
Reviewed-by: Dan Kenigsberg <[email protected]>
Tested-by: Dan Kenigsberg <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/29553
Reviewed-by: Yaniv Bronhaim <[email protected]>
---
M vdsm/rpc/BindingXMLRPC.py
1 file changed, 29 insertions(+), 7 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit http://gerrit.ovirt.org/29553
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to