Dan Kenigsberg has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 ......................................................................
Patch Set 7: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/30532/7/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 60: IP_GATEWAY = '240.0.0.254' Line 61: # Current implementation converts ip to its 32 bit int representation Line 62: IP_TABLE = '4026531841' Line 63: DHCP_RANGE_FROM = '240.0.0.10' Line 64: DHCP_RANGE_TO = '240.0.0.100' Please make the dhcp6 test similar to the existing one (with DHCP6_RANGE_FROM etc) Line 65: CUSTOM_PROPS = {'linux': 'rules', 'vdsm': 'as well'} Line 66: Line 67: IPv6_ADDRESS = 'fdb3:84e5:4ff4:55e3::1' Line 68: IPv6_CIDR = '64' Line 95: @contextmanager Line 96: def dnsmasqDhcp(interface, family=4): Line 97: """Manages the life cycle of dnsmasq as a DHCP server.""" Line 98: dhcpServer = dhcp.Dnsmasq() Line 99: rangeFrom, rangeTo = ( please research a bit more - can we supply the 2 ranges, one for ipv4 and another for ipv6 in a single command line? Line 100: family == 4 and (DHCP_RANGE_FROM, DHCP_RANGE_TO) Line 101: or (DHCPv6_ADDRESS, DHCPv6_ADDRESS)) Line 102: Line 103: try: Line 1845: @permutations([[(True, 4)], [(True, 6)], [(False, 4)], [(False, 6)]]) Line 1846: @cleanupNet Line 1847: @RequireVethMod Line 1848: @ValidateRunningAsRoot Line 1849: def testSetupNetworksAddDelDhcp(self, (bridged, family)): in a followup patch, please add a test for setting both ipv4 and ipv6 addresses on the same setupNetowrk command. Line 1850: with vethIf() as (left, right): Line 1851: addr, cidr = ( Line 1852: family == 4 and (IP_ADDRESS, IP_CIDR) Line 1853: or (IPv6_ADDRESS, IPv6_CIDR)) -- To view, visit http://gerrit.ovirt.org/30532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5d821edd54681a7a8c1013a90af61ae835baa39 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
