Dan Kenigsberg has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29953/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 185: Line 186: def __init__(self, vm): Line 187: AdvancedStatsThread.__init__(self, log=vm.log, daemon=True) Line 188: self._vm = vm Line 189: # ugly hack to preserve backward compatibility I see no reason to keep a separate vm_sample_disk_latency_interval or ANY window != 2. Please merge vm_sample_disk_latency_interval into vm_sample_disk_interval in a separate patch. Line 190: self._splitDiskStats = ( Line 191: (config.getint('vars', 'vm_sample_disk_interval') != Line 192: config.getint('vars', 'vm_sample_disk_latency_interval')) Line 193: or -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
