Martin Polednik has posted comments on this change. Change subject: vdsm: add check for hostdev passthrough to caps ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/30471/2/vdsm/caps.py File vdsm/caps.py: Line 250: if 'intel_iommu' in cmdline: Line 251: if 'intel_iommu=off' not in cmdline or 'iommu=off' not in cmdline: Line 252: return 'yes' Line 253: Line 254: return 'no' > why not just thanks for the suggestion, actually makes sense; about checking for enabled - iommu can be anbled via =on but also =igfx_off for example, therefore as long as its there and not off we can assume that it's configured to work Line 255: Line 256: Line 257: def _getIommuSupport(): Line 258: try: Line 266: except: Line 267: with open('/var/log/dmesg', 'r') as fd: Line 268: for index, line in enumerate(fd): Line 269: if 'Command line:' in line: Line 270: return _iommuPresent(line) > same here, probably /proc/cmdline is simpler and provides just what you nee great suggestion, was looking for something like that Line 271: Line 272: return 'no' Line 273: Line 274: -- To view, visit http://gerrit.ovirt.org/30471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
