Adam Litke has posted comments on this change. Change subject: Live Merge: Ignore libvirt block job events ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/30046/8/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5311: self.log.debug("Still waiting for block job %s to be " Line 5312: "cleaned up", jobID) Line 5313: elif not cleanThread.isSuccessful(): Line 5314: # At this point we know the thread is not alive and the Line 5315: # cleanup failed. Retry it with a new thread. > can this be repeated indefinitedly or will libvirt eventually give up? At this point libvirt is not involved anymore. It has either completed the merge or it has failed. If we continue to fail it's due to storage connectivity issues. But in any case, the retry loop would be limited to the current execution of the VM. Line 5316: startCleanup(storedJob, drive) Line 5317: jobsRet[jobID] = entry Line 5318: return jobsRet Line 5319: -- To view, visit http://gerrit.ovirt.org/30046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbcdca4c0c0e45e9323ecfef9ce2fce10d8451a5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
