Francesco Romani has posted comments on this change. Change subject: vm: set status before to invoke suspend ......................................................................
Patch Set 4: -Code-Review (3 comments) fixed to use the guestCpuLock http://gerrit.ovirt.org/#/c/29113/4//COMMIT_MSG Commit Message: Line 16: which makes a Vm incorrectly reported as 'Paused' Line 17: (instead of 'Saving State'), which confuses Engine. Line 18: Line 19: The definitive fix is of course make sure the state changes inside the Line 20: Vm are atomic ad well handled, but this will require an overhaul > ad->and Done Line 21: of the Vm class internals. Line 22: Line 23: This patch provides a first step towards better state handling, Line 24: in the form of a new method to update the VM status, which Line 21: of the Vm class internals. Line 22: Line 23: This patch provides a first step towards better state handling, Line 24: in the form of a new method to update the VM status, which Line 25: will encapsulete the nasty details. > encapsulate Done Line 26: Line 27: The fix is done by changing the internal state before to attempting Line 28: the operation and by providing state rollback in case of failures. Line 29: Line 23: This patch provides a first step towards better state handling, Line 24: in the form of a new method to update the VM status, which Line 25: will encapsulete the nasty details. Line 26: Line 27: The fix is done by changing the internal state before to attempting > s/to attempting/attempting/ Done Line 28: the operation and by providing state rollback in case of failures. Line 29: Line 30: Change-Id: I3aea96c7122d60e6cb888273678b565c3f3e537f Line 31: Bug-Url: https://bugzilla.redhat.com/1111938 -- To view, visit http://gerrit.ovirt.org/29113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aea96c7122d60e6cb888273678b565c3f3e537f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
