Adam Litke has posted comments on this change. Change subject: Live Merge: Ignore libvirt block job events ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/30046/10/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5538: self.vm.log.info("Starting live merge cleanup for job %s", Line 5539: self.jobId) Line 5540: try: Line 5541: self.vm.handleBlockJobEvent(self.jobId, self.drive, 'finished') Line 5542: except Exception: > I do not understand the benefit of this try-block. we already log above the My reasoning is that I'd like to print an explanatory message here that is correlated with the jobID to aid in debugging. Just a traceback would lack that context especially if multiple block jobs are running simultaneously. Line 5543: self.vm.log.warning("Cleanup failed for live merge job %s", Line 5544: self.jobId) Line 5545: raise Line 5546: else: -- To view, visit http://gerrit.ovirt.org/30046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbcdca4c0c0e45e9323ecfef9ce2fce10d8451a5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
