Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add time per test if nose-timer is available
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30171/1/tests/testrunner.py
File tests/testrunner.py:

Line 48:     timer_plugin = TimerPlugin()
Line 49:     timer_plugin.enabled = True
Line 50:     timer_plugin.timer_ok = 500  # Okay <= 500ms
Line 51:     timer_plugin.timer_warning = 5000  # Warn > 5s
Line 52:     timer_plugin.timer_no_color = False  # Enable color output
> These defaults are not correct for all tests.
these numbers are indeed a bit arbitrary, but the alternative of tweaking the 
plugin and running all over our tests defining acceptable times do not sound 
appealing, either.

Can we drop colours instead?
Line 53: 
Line 54: from testValidation import SlowTestsPlugin, StressTestsPlugin
Line 55: 
Line 56: import zombiereaper


-- 
To view, visit http://gerrit.ovirt.org/30171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4960b30532a84abd259fb268c7e40a1751847a96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to