Michal Skrivanek has posted comments on this change. Change subject: refine calculation of cpu topology ......................................................................
Patch Set 3: (1 comment) looks ok. @Francesco: Still it's engine's responsibility to calculate topology, here we just limit for sane maximum for future hotplug http://gerrit.ovirt.org/#/c/30896/3/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 428: cores = int(self.conf.get('smpCoresPerSocket', '1')) Line 429: threads = int(self.conf.get('smpThreadsPerCore', '1')) Line 430: sockets = int(self.conf.get('maxNumberOfSockets', '16')) Line 431: maxVCpus = int(self.conf.get('maxVCpus', self._getSmp())) Line 432: maxVCpus = maxVCpus if cores * sockets > maxVCpus else cores * sockets don't we have something like a max(a, b) function? Line 433: Line 434: self._topology = { Line 435: 'cores': cores, Line 436: 'threads': threads, -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
