Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Ensure that host id is released ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/30922/1/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 190: if self.domain and not self.isIsoDomain: Line 191: try: Line 192: self.domain.releaseHostId(self.hostId, unused=True) Line 193: except: Line 194: self.log.debug("Unable to release the host id %s for " This should become log.exception. If you have time you can send a separate patch where you fix these for the entire file. Line 195: "domain %s", self.hostId, self.sdUUID, Line 196: exc_info=True) Line 197: Line 198: def _monitorLoop(self): -- To view, visit http://gerrit.ovirt.org/30922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99b8a11b055a671d180feff92500091b3e0e1287 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
