Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Extract domain monitoring methods ......................................................................
domainMonitor: Extract domain monitoring methods The _domainMonitor method was extremely long and was doing too much. This patch breaks it to multiple small methods to make it easier to understand and modify. One of the planned changes is to allow _domainMonitor to abort in the middle if a monitor is stopped. Implementing this in the original method would only make it worse. To make it easy, operation that may take lot of time were extracted into separate methods. This patch does not change the behavior of the monitor, only move code around. Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/27714 Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/storage/domainMonitor.py 1 file changed, 110 insertions(+), 67 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
