Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: logging requests and responses ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30923/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 457: self._workQueue.put_nowait(req) Line 458: Line 459: def _serveRequest(self, ctx, req): Line 460: mangledMethod = req.method.replace(".", "_") Line 461: self.log.debug("Calling '%s' in bridge with %s", Since getVdsStats() and list() are so frequest, in binding_xmlrpc, we decided not to log them in DEBUG level. How about doing the same here? Line 462: req.method, req.params) Line 463: try: Line 464: method = getattr(self._bridge, mangledMethod) Line 465: except AttributeError: -- To view, visit http://gerrit.ovirt.org/30923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1785d466725310c711aef9ef1dadc60364a21bce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
