Dan Kenigsberg has submitted this change and it was merged.
Change subject: net_configurators: Fix optional configurator importing
......................................................................
net_configurators: Fix optional configurator importing
With the arrival of the first truly optional (its dependencies do not
need to be installed) configurator, i.e., pyroute_two, a flaw in my
getConfiguratorClass was exposed.
With this patch, all configurators should explicitly define a
is_available()
method that returns True if it is required and False if it is
optional and some of its dependencies are missing. Additionally,
all the extra dependency importing should not raise.
Change-Id: Iff38f5e334167e34ba379be164e690f2888f5fea
Signed-off-by: Antoni S. Puimedon <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/30924
Reviewed-by: Federico Simoncelli <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
Tested-by: Dan Kenigsberg <[email protected]>
---
M vdsm/network/configurators/ifcfg.py
M vdsm/network/configurators/iproute2.py
M vdsm/network/configurators/pyroute_two.py
M vdsm/vdsm-restore-net-config
4 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Federico Simoncelli: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff38f5e334167e34ba379be164e690f2888f5fea
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
