Nir Soffer has posted comments on this change. Change subject: schedule: Introduce scheduling library ......................................................................
Patch Set 12: This version includes few optimizations based on profiling done in http://gerrit.ovirt.org/30987. - Drop the useless user wrapper around a scheduled call. Now we create one object per call, and return it to the user to allow canceling. - Keep calls in tuple (dedaline, call), which makes heappush faster, since it does not have to invoke ScheduledCall.__cmp__ millions of times - Wakeup scheduler only if scheduled call was scheduled first. There is no reason to wake up the scheduler in other cases - Drop canceled calls when popping out expired calls, previouly were returned in the list of expired calls, and were executed (noop). - Remove deadline from ScheduledCall, as the deadline is stored in the tuple - Use __slots__ in ScheduledCall to minimize memory usage -- To view, visit http://gerrit.ovirt.org/29607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3764806d93bd37c3b5924080eb5ae4d29e4f4e0 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
