Dan Kenigsberg has posted comments on this change. Change subject: Veth devices are shown as NICs ......................................................................
Patch Set 1: Code-Review-1 (2 comments) This used to work in the past, and now it does not. Hence, we must add a unit test we don't break it again. Please include a test that mocks Link._fakeNics, creates a veth device, and verified that it is reported (or ignored) accordingly. http://gerrit.ovirt.org/#/c/31028/1//COMMIT_MSG Commit Message: Line 8: Line 9: Veth and dummy LinkTypes were not listed in tuple, therefore they Line 10: were evaluated as NICs. Line 11: Line 12: Bug 1125177 (https://bugzilla.redhat.com/show_bug.cgi?id=1125177) Please use Bug-Url: https://bugzilla.redhat.com/1125177 Line 13: Line 14: Change-Id: Iff436c492628977914b0ef5499906bacce9315a5 http://gerrit.ovirt.org/#/c/31028/1/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 159: if ioe.errno == errno.EOPNOTSUPP: Line 160: if name == 'lo': Line 161: detectedType = LinkType.LOOPBACK Line 162: else: Line 163: detectedType = LinkType.DUMMY DUMMY is identified here, and returned before the changed line. Thus, I think that the commit message is not precise. Line 164: return detectedType Line 165: else: Line 166: raise # Reraise other errors like ENODEV Line 167: if driver in (LinkType.BRIDGE, LinkType.MACVLAN, LinkType.TUN, -- To view, visit http://gerrit.ovirt.org/31028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff436c492628977914b0ef5499906bacce9315a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
