Dan Kenigsberg has posted comments on this change. Change subject: tc: add qdisc parsing for some hfsc, ingress, pfifo_fast, etc ......................................................................
Patch Set 8: Code-Review-1 (2 comments) It may sound as a silly request, but I actually need it: could you explain how a qdisc defintion is splitted? http://gerrit.ovirt.org/#/c/30048/8/vdsm/network/tc/qdisc.py File vdsm/network/tc/qdisc.py: Line 31: return _wrapper.process_request(command) Line 32: Line 33: Line 34: def parse(tokens): Line 35: """Takes a token generator""" could you give here an example of a qdisc line, explaining which is the "spec", where is the "kind"? Line 36: kind = next(tokens) Line 37: data = {'kind': kind, 'handle': next(tokens)} Line 38: for token in tokens: Line 39: if token == 'root': Line 42: data[token] = _parser.parse_str(tokens) Line 43: elif token == 'refcnt': Line 44: data[token] = _parser.parse_int(tokens) Line 45: else: Line 46: break # Finished with generat qdisc attrs generat->general Line 47: Line 48: spec_parser = _spec.get(kind, ()) Line 49: while True: Line 50: if token in spec_parser: -- To view, visit http://gerrit.ovirt.org/30048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I039dc7594a261ccb32f78c0b050b28fecac417ee Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
