Federico Simoncelli has posted comments on this change. Change subject: sp: fix storage domain link detection ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30245/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1118: @unsecured Line 1119: def _linkStorageDomain(self, src, linkName): Line 1120: self.log.info("Linking %s to %s", src, linkName) Line 1121: try: Line 1122: current = os.readlink(linkName) > current it not very clear, and it is not clear that you should compare curr I am worried that linkSrc can be confused with what "src" is. What about: def _linkStorageDomain(self, linkTarget, linkName): ... currentLinkTarget = os.readlink(linkName) ... else: if linkTarget == currentLinkTarget: ... linkTarget/Name are the official arguments of "ln", it is nice to maintain the names. Line 1123: except OSError as e: Line 1124: if e.errno != errno.ENOENT: Line 1125: self.log.error("Can't link SD %s to %s", src, linkName, Line 1126: exc_info=True) -- To view, visit http://gerrit.ovirt.org/30245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37b44ac15f24be1271334e15ef47fc8316f259eb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
