Dan Kenigsberg has posted comments on this change. Change subject: rpm: make vdsm-python package noarch ......................................................................
Patch Set 1: Code-Review-1 It's more than plain forgetfulness. On EL6, one cannot have a top rpm noarch with subpackage (like safelease) being arch-specific. As it is, you patch never creates a package that pulls dmidecode during deployment. At the very least, this should be handled by ovirt-host-deploy and ovirt-node creation. I think you can (and should) drop all the explicit noach from subpackages. P.S. I do not mind abandoning my own attempt http://gerrit.ovirt.org/30678 -- To view, visit http://gerrit.ovirt.org/31071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04b78b9e566cdea8538b18a83996739779ce98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
