Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Refine names ......................................................................
domainMonitor: Refine names The domain monitor use to have monitoredDomains and poolMonitoredDomains properties. The word "monitored" in these names is unneeded, as the class is called DomainMonitor, and it does not keep other lists of domains. I replaced the _domains variable to the more specific _monitors, since this dict keep domain monitors, not domain objects. This is required now to prevent confusion, since the new domains property does not return the dict but its keys. Finally, when we get a monitor from the _monitor dict, we call it monitor instead of domainThread. It is true that this object is related to a domain and it run in a thread, but responsibility of this object is monitoring. Change-Id: I141d4a0baf6b72ddfa5075052f7f4b24ce336a1a Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29532 Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> --- M vdsm/storage/domainMonitor.py M vdsm/storage/hsm.py M vdsm/storage/sp.py 3 files changed, 21 insertions(+), 22 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I141d4a0baf6b72ddfa5075052f7f4b24ce336a1a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
