Nir Soffer has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/28873/9/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py: Line 266: Line 267: def getHostStatus(self, hostId): Line 268: # Note: get_hosts has off-by-one bug when asking for particular host Line 269: # id, so get all hosts info and filter. Line 270: # See https://bugzilla.redhat.com/1111210 > And this is not fixed yet?! Fixed upstream: https://git.fedorahosted.org/cgit/sanlock.git/commit/?id=2e5150be0ad662f218a5442bd1c40f12c825022d I ask David again to backport this. Line 271: try: Line 272: hosts = sanlock.get_hosts(self._sdUUID) Line 273: except sanlock.SanlockException as e: Line 274: self.log.debug("Unable to get host %d status in lockspace %s: %s", http://gerrit.ovirt.org/#/c/28873/9/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3635: @deprecated Line 3636: @public Line 3637: def startMonitoringDomain(self, sdUUID, hostID, options=None): Line 3638: with rmanager.acquireResource(STORAGE, HSM_DOM_MON_LOCK, Line 3639: rm.LockType.exclusive): > Please investigate if we need these locks at all. I feel that we have other I'll add this to my todo list. Line 3640: self.domainMonitor.startMonitoring(sdUUID, int(hostID), False) Line 3641: Line 3642: @deprecated Line 3643: @public -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
