Dan Kenigsberg has posted comments on this change. Change subject: fileSD: include gluster in getMountsList ......................................................................
Patch Set 3: Code-Review-1 (3 comments) I'd like to increase coverage - would you add a unit test for scanDomains? http://gerrit.ovirt.org/#/c/30934/3/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 56: Line 57: # Specific stat(2) block size as defined in the man page Line 58: ST_BYTES_PER_BLOCK = 512 Line 59: Line 60: MOUNTLIST_IGNORE = ('/' + sd.BLOCKSD_DIR, '/' + sd.GLUSTERSD_DIR) Should this really be public? I don't expect it to be used out of getMountsList() Line 61: Line 62: getProcPool = oop.getGlobalProcPool Line 63: Line 64: Line 640: self.log.debug("Force linking %s to %s", tVol, tLink) Line 641: self.oop.utils.forceLink(tVol, tLink) Line 642: Line 643: Line 644: def getMountsList(pattern="*"): this function should have been declared _private (unrelated to this patch) Line 645: fileDomPattern = os.path.join( Line 646: sd.StorageDomain.storage_repository, sd.DOMAIN_MNT_POINT, Line 647: pattern) Line 648: Line 648: Line 649: # For pattern='*' in mixed pool (block and file domains) Line 650: # glob will return sd.BLOCKSD_DIR and sd.GLUSTERSD_DIR among Line 651: # real mount points. Remove sd.BLOCKSD_DIR from glob results. Line 652: mntList = [mnt for mnt in glob.glob(fileDomPattern) iglob() would avoid creating a temporary list Line 653: if not mnt.endswith(MOUNTLIST_IGNORE)] Line 654: Line 655: glusterDomPattern = os.path.join( Line 656: sd.StorageDomain.storage_repository, sd.DOMAIN_MNT_POINT, -- To view, visit http://gerrit.ovirt.org/30934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81600a68bbea99c1079bf153cf2c105c6fe73f70 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
