Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/31155
to review the following change.
Change subject: sp: fix storage domain link detection
......................................................................
sp: fix storage domain link detection
It seems that the storage domain link detection never worked. This patch
fixes the intended behavior.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1116585
Change-Id: I37b44ac15f24be1271334e15ef47fc8316f259eb
Signed-off-by: Federico Simoncelli <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/30245
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/storage/sp.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/31155/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 2b4f2ce..0ce00fc 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1126,7 +1126,9 @@
exc_info=True)
return
else:
- if current == linkName:
+ if current == src:
+ self.log.debug('link already present skipping creation '
+ 'for %s', linkName)
return # Nothing to do
# Rebuild the link
tmp_link_name = os.path.join(self.storage_repository,
--
To view, visit http://gerrit.ovirt.org/31155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37b44ac15f24be1271334e15ef47fc8316f259eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
