Hello Nir Soffer, Dan Kenigsberg, Allon Mureinik,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/31157

to review the following change.

Change subject: sp: add logging for stale domain link collection
......................................................................

sp: add logging for stale domain link collection

This patch adds logging to the stale domain link collection in order to
better track links life-cycle.

Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1116585
Change-Id: Ia0aabbf62ab347e34e9d4efe922ea95d33290ef6
Signed-off-by: Federico Simoncelli <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/30246
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-by: Allon Mureinik <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/31157/1

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 5d28f15..01fcc5f 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1218,6 +1218,7 @@
 
         # Cleanup old trash from the pool
         for oldie in oldLinks:
+            self.log.debug('collecting stale storage domain link %s', oldie)
             try:
                 os.remove(oldie)
             except OSError as e:


-- 
To view, visit http://gerrit.ovirt.org/31157
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0aabbf62ab347e34e9d4efe922ea95d33290ef6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to