Petr Horáček has uploaded a new change for review. Change subject: dummies and veths with changeable prefix ......................................................................
dummies and veths with changeable prefix Veth's and dummy's create() functions have unrequired attribute prefix. Change-Id: I7f8bd58abd5cbf73ad69b0e668d1dde83d247d05 Signed-off-by: Petr Horáček <[email protected]> --- M tests/functional/dummy.py M tests/functional/veth.py 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/31164/1 diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py index aa56c71..f1b3585 100644 --- a/tests/functional/dummy.py +++ b/tests/functional/dummy.py @@ -23,7 +23,7 @@ from vdsm.ipwrapper import linkAdd, linkDel, addrAdd, linkSet, IPRoute2Error -def create(): +def create(prefix='dummy_'): """ Creates a dummy interface, in a fixed number of attempts (100). The dummy interface created has a pseudo-random name (e.g. dummy_85 @@ -31,7 +31,7 @@ """ for i in random.sample(range(100), 100): - dummy_name = 'dummy_%s' % i + dummy_name = '%s%s' % (prefix, i) try: linkAdd(dummy_name, linkType='dummy') except IPRoute2Error: diff --git a/tests/functional/veth.py b/tests/functional/veth.py index 5d5ccd5..bb5adbd 100644 --- a/tests/functional/veth.py +++ b/tests/functional/veth.py @@ -24,15 +24,15 @@ from vdsm.ipwrapper import linkAdd, IPRoute2Error -def create(): +def create(prefix='veth_'): """ Creates a veth interface with a pseudo-random name for both endpoints (e.g. veth_85 and veth_31 in the format veth_Number). Assumes root privileges. """ deviceNumbers = random.sample(range(100), 2) - leftPoint = 'veth_%s' % deviceNumbers[0] - rightPoint = 'veth_%s' % deviceNumbers[1] + leftPoint = '%s%s' % (prefix, deviceNumbers[0]) + rightPoint = '%s%s' % (prefix, deviceNumbers[1]) try: linkAdd(leftPoint, linkType='veth', args=('peer', 'name', rightPoint)) except IPRoute2Error: -- To view, visit http://gerrit.ovirt.org/31164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7f8bd58abd5cbf73ad69b0e668d1dde83d247d05 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
