Nir Soffer has posted comments on this change. Change subject: fencing: Skip fencing if host is maintaining its lease ......................................................................
Patch Set 8: Code-Review+1 (1 comment) Ok, using a policy for all "set" actions makes sense, even if checking lease does not make sense, we may have another policy that does make sense. Other then the minor indentation, I think this fine. http://gerrit.ovirt.org/#/c/30762/8/vdsm/API.py File vdsm/API.py: Line 1198: Line 1199: if action not in ('status', 'on', 'off', 'reboot'): Line 1200: raise ValueError('illegal action ' + action) Line 1201: Line 1202: if action != 'status' and not should_fence(policy): > >When you return {"operationStatus": "skipped"}, does engine abort the fenc ok Line 1203: self.log.debug("Skipping execution of action '%s'", action) Line 1204: return {'status': doneCode, 'operationStatus': 'skipped'} Line 1205: Line 1206: script = constants.EXT_FENCE_PREFIX + agent -- To view, visit http://gerrit.ovirt.org/30762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1fd9521cebea28d0402e53d46d74b95e73f383 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
