Yaniv Bronhaim has submitted this change and it was merged. Change subject: image: Detect cycles in image volume chain ......................................................................
image: Detect cycles in image volume chain When sorting volume chains, we could get into an endless loop if there was a cycle in the volume chain, for example, a volume claiming to be its own parent. The endless loop create a new volume object on each iteration, and adds it to the chain list, and will stop only when no more memory is available or vdsm is stopped. Now ImageIsNotLegalChain is raised as soon as a cycle is detected. Change-Id: I687335f17bc7810071ba3523cba8ad980e7d5bdb Bug-Url: https://bugzilla.redhat.com/1125197 Relates-To: https://bugzilla.redhat.com/1124498 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30867 Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30944 --- M vdsm/storage/image.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687335f17bc7810071ba3523cba8ad980e7d5bdb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
