Yaniv Bronhaim has submitted this change and it was merged. Change subject: Live Merge: Stop scanning volume chains at VM startup ......................................................................
Live Merge: Stop scanning volume chains at VM startup During VM create (or recovery) we are scanning the volume chain of each disk to catch and handle metadata sync issues. These can happen if a block job completed while vdsm was not running or if a block job completed when the VM was running on another host but the metadata could not be corrected before it was restarted on this host. Both of these negative flows are relatively rare but the volume chain scanning code incurs a startup penalty on every create/recoverVM. Drop the scanning and handle these cases differently. To address the first scenario, we are going to move away from using the libvirt events and rely solely on our cached _blockJobs info stored in the VM recovery file. For the second case, we are going to cooperate with the engine and allow it to resubmit the same live merge command when the end state of the first submission is ambiguous. Vdsm will handle the resubmit by ensuring the metadata is synchronized. Change-Id: I48ba5dd9a70f6daa9bb9da94c2f06296f2b788da Signed-off-by: Adam Litke <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30045 Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Michal Skrivanek <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124970 Reviewed-on: http://gerrit.ovirt.org/31047 Reviewed-by: Yaniv Bronhaim <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Adam Litke: Verified Yaniv Bronhaim: Looks good to me, approved Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48ba5dd9a70f6daa9bb9da94c2f06296f2b788da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
