Antoni Segura Puimedon has posted comments on this change. Change subject: network/api.py: delete network's orphans ......................................................................
Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31018/5/vdsm/network/api.py File vdsm/network/api.py: Line 725: try: Line 726: addNetwork(network, configurator=configurator, Line 727: implicitBonding=True, _netinfo=_netinfo, **d) Line 728: except ConfigNetworkError as cne: Line 729: if cne.errCode == 29: what's '29'. It looks like a magic number. If it comes from neterrors, please, import the constant and use its name. Line 730: logger.debug("Adding network %r failed. Running " Line 731: "orphan-devices cleanup", network) Line 732: _emergencyNetworkCleanup(network, networkAttrs, Line 733: configurator) -- To view, visit http://gerrit.ovirt.org/31018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id14d109d67c5906bc85a2fcf98dfabd61d96da13 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
