Federico Simoncelli has posted comments on this change. Change subject: tests: Introduce AssertingLock ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30938/1/tests/testlib.py File tests/testlib.py: Line 335: return result Line 336: return result[:_MAX_LENGTH] + ' [truncated]...' Line 337: Line 338: Line 339: class AssertingLock(object): Maybe it's worth renaming this to AssertSingleLock? Line 340: """ Line 341: Lock that raises when trying to acquire a locked lock. Line 342: """ Line 343: def __init__(self): -- To view, visit http://gerrit.ovirt.org/30938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3aad4015e3410ce2f2b39bba84314cce5580b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
