Francesco Romani has posted comments on this change.

Change subject: Live Merge: Return more info from _driveGetActualVolumeChain
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/31364/1//COMMIT_MSG
Commit Message:

Line 11: given in the domain XML in order to properly update our metadata after
Line 12: an active layer merge.  We also want to use this function to return 
high
Line 13: write watermark information for block volumes.  This patch just 
converts
Line 14: the format returned by _driveGetActualVolumeChain from a simple list to
Line 15: a list of dictionaries.
I wonder if namedtuples would be better here. I have a little preference for 
them.
Line 16: 
Line 17: Change-Id: I01d142a68903048accc95eb04d9930c326965db0
Line 18: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109920


-- 
To view, visit http://gerrit.ovirt.org/31364
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01d142a68903048accc95eb04d9930c326965db0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to