Dan Kenigsberg has posted comments on this change. Change subject: vm: more generic recovery check ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/31241/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 108: vm = libvirtCon.lookupByID(domId) Line 109: xmlDom = vm.XMLDesc(0) Line 110: except libvirt.libvirtError as e: Line 111: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 112: logging.error("domId: %s is dead", domId, exc_info=True) error->exception Line 113: else: Line 114: logging.error("Can't look for domId: %s, code: %s", Line 115: domId, e.get_error_code(), exc_info=True) Line 116: raise Line 111: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 112: logging.error("domId: %s is dead", domId, exc_info=True) Line 113: else: Line 114: logging.error("Can't look for domId: %s, code: %s", Line 115: domId, e.get_error_code(), exc_info=True) the stack trace would be logged by the caller, since we re-raise. you may log the failed vmId, though. Line 116: raise Line 117: else: Line 118: yield vm, xmlDom Line 119: -- To view, visit http://gerrit.ovirt.org/31241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0cc57129e9c8e6545f9a947329adf1f9e82648f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
