Dan Kenigsberg has submitted this change and it was merged. Change subject: Veth devices are shown as NICs + test ......................................................................
Veth devices are shown as NICs + test Veth LinkType was not listed in tuple, therefore veths were evaluated as NICs. New test adds dummies and veths with _fakeNics prefix and with non _fakeNics prefix and then verify if fake nics are shown in netinfo.nics() and the others are not. Bug-Url: https://bugzilla.redhat.com/1125177 Change-Id: Ide618510b46eee28d939c32e8188bbd38349d660 Signed-off-by: Petr Horáček <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31166 Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Tested-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/ipwrapper.py M tests/netinfoTests.py 2 files changed, 25 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide618510b46eee28d939c32e8188bbd38349d660 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
