Federico Simoncelli has posted comments on this change. Change subject: sparsify: integrating virt-sparsify into vdsm ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/28328/14/vdsm/storage/image.py File vdsm/storage/image.py: Line 546: Line 547: tmpVolume = self._getSparsifyVolume(tmpSdUUID, tmpImgUUID, tmpVolUUID) Line 548: dstVolume = self._getSparsifyVolume(dstSdUUID, dstImgUUID, dstVolUUID) Line 549: Line 550: if not tmpVolume.isSparse() or not dstVolume.isSparse(): > In your comment (see http://gerrit.ovirt.org/#/c/28328/13..14/vdsm/storage/ Probably the correct check here would be that tmpVolume format is COW. Anyway since earlier we got the parent it's pretty much implied. dstVolume.isSparse is mandatory because otherwise the operation wouldn't make sense. We could drop the tmpVolume check. Line 551: raise se.VolumeNotSparse() Line 552: Line 553: srcVolume = self._getSparsifyVolume(tmpSdUUID, tmpImgUUID, Line 554: tmpVolume.getParent()) -- To view, visit http://gerrit.ovirt.org/28328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bd2b4b6d45781fa27a128dd68d14b7561d0901 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Utkarsh Singh <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
