Dan Kenigsberg has posted comments on this change. Change subject: signals: Handle signals to non-main threads ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/29392/10/lib/vdsm/sigutils.py File lib/vdsm/sigutils.py: Line 89: Line 90: try: Line 91: events = _signal_poller.poll(timeout) Line 92: if events: Line 93: _empty_pipe(_signal_read_fd) Afaict, _empty_pipe() does not raise socket.error, so calling it misleading. Please place in try's except clause. Line 94: except select.error as e: Line 95: if e[0] == errno.EINTR: Line 96: # We need to clean up the pipe Line 97: _empty_pipe(_signal_read_fd) http://gerrit.ovirt.org/#/c/29392/10/tests/sigutilsTests_child.py File tests/sigutilsTests_child.py: Line 1: #!/usr/bin/python -u Lawyers love GPL boilerplate on every code file. Line 2: import os Line 3: import signal Line 4: import subprocess Line 5: import sys Line 28: Line 29: Line 30: def test_signal_to_thread(): Line 31: ''' Line 32: This tests checks the following scenario: tests->test Line 33: * main thread is waiting for signal Line 34: * another thread is running a subprocess Line 35: * the subprocess exits before another thread dies Line 36: -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
