mooli tayer has posted comments on this change. Change subject: vdsm-tool: simplify getting modules by names. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31464/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 49: args = _parse_args(*args) Line 50: configurer_to_trigger = [] Line 51: Line 52: sys.stdout.write("\nChecking configuration status...\n\n") Line 53: for c in args.modules: > don't understand this change.. c its just a string in this part. doesn't it After parse args args.modules are actual modules. see line 197. Also see that that caused this patch: http://gerrit.ovirt.org/#/c/31562/1/lib/vdsm/tool/configurators/certificates.py,cm line 189. Line 54: isconfigured = c.isconfigured() Line 55: override = args.force and isconfigured != CONFIGURED Line 56: if not override and not c.validate(): Line 57: raise InvalidConfig( Line 50: configurer_to_trigger = [] Line 51: Line 52: sys.stdout.write("\nChecking configuration status...\n\n") Line 53: for c in args.modules: Line 54: isconfigured = c.isconfigured() > why the temp var? I remember it was made to be similar with the code before the change inserting it. Do you want another patch fixing this? Line 55: override = args.force and isconfigured != CONFIGURED Line 56: if not override and not c.validate(): Line 57: raise InvalidConfig( Line 58: "Configuration of %s is invalid" % c.getName() -- To view, visit http://gerrit.ovirt.org/31464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb056e18573b1aadefe57a6eee4ec1396dad9775 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
