Dan Kenigsberg has posted comments on this change. Change subject: networkTests: assertBondDoesntExist with nics=None ......................................................................
Patch Set 5: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/31334/5/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 241: def assertBondDoesntExist(self, bondName, nics=None): Line 242: netinfo = self.vdsm_net.netinfo Line 243: config = self.vdsm_net.config Line 244: if nics is None: Line 245: self.assertNotIn(bondName, netinfo.bondings, > but if the first assert pass (there is no bond) the second must fail with I Oh sorry, you are right. I flipped "or" and "and". Line 246: '%s found unexpectedly' % bondName) Line 247: else: Line 248: self.assertTrue(bondName not in netinfo.bondings or (set(nics) != Line 249: set(netinfo.bondings[bondName]['slaves'])), -- To view, visit http://gerrit.ovirt.org/31334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43da6b2b6d7cfb79a64c37600477a69831acbf94 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
