Francesco Romani has posted comments on this change. Change subject: virt: keep on sampling before /var/run/vdsm/client.log exists ......................................................................
Patch Set 1: Code-Review+1 Looks good to me. Suggestion for possible improvements (future patches) - add test(s). This issue dodged the first review cycle, and it is nasty enough to deserve a test to make sure it will not fade away from our memories. - factorize this common code somehow, maybe an utils function is enough. -- To view, visit http://gerrit.ovirt.org/31619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7d380882f5a93e5c75eda80598f382744b178c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
