Francesco Romani has posted comments on this change. Change subject: Send to cannonizeHostPort port parameter as string instead of integer. ......................................................................
Patch Set 2: In general, a good verification involve to check all (or at least the main) affected flows on a live oVirt environment. This means patch VDSM, install it, and run the flows. For trivial or not-hot patches, it may be sufficient to run functional tests and/or unit tests, if the changed code is already well covered - or covered by new tests. In this case, I believe it is enough to make sure your change does not affect migrations and fixes your bug in the hosted engine environment. I can help verifying the common migration scenario (Engine on a separate box, not hosted) if there is need. -- To view, visit http://gerrit.ovirt.org/31209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a3082abee5f27f84a7731d783027a30fa02d846 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
