Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Raise UsageError when used incorrectly ......................................................................
tool: Raise UsageError when used incorrectly Commit e5e80540e8 added a new type of error, when user try to configure non existing module. The test for this feature expect a SystemExit exception, but the code was actualy raising a KeyError. Seems that both the test and the code are wrong, so now a UsageError is raised in this case. Change-Id: I8e0528c84b41eee56c141d725c837cf48df5d186 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31735 Reviewed-by: mooli tayer <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurator.py M tests/toolTests.py 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e0528c84b41eee56c141d725c837cf48df5d186 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
