Francesco Romani has posted comments on this change. Change subject: vm, guestagent: return hash should include also the disk mapping ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/31701/4/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 26: import unicodedata Line 27: Line 28: # TODO: in future import from .. Line 29: import supervdsm Line 30: import json not needed, see line 25 above Line 31: Line 32: from . import vmstatus Line 33: Line 34: _MAX_SUPPORTED_API_VERSION = 1 http://gerrit.ovirt.org/#/c/31701/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4514: def _getUnderlyingVmInfo(self): Line 4515: self._lastXMLDesc = self._dom.XMLDesc(0) Line 4516: devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \ Line 4517: getElementsByTagName('devices')[0] Line 4518: self._devXmlHash = hash(devxml.toxml()) OK, now I see why you removed the str() here and changed type on line 1547. It is about how this field it is used, because after your patch it becomes only part of the final hash, and it is no longer the field being published. It makes sense. I'm OK with it. Line 4519: Line 4520: return self._lastXMLDesc Line 4521: Line 4522: def _ejectFloppy(self): -- To view, visit http://gerrit.ovirt.org/31701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
