Nir Soffer has posted comments on this change. Change subject: Live Merge: Return more info from _driveGetActualVolumeChain ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31364/4//COMMIT_MSG Commit Message: Line 9: In followup patches, we want to return more information about each path Line 10: component from _driveGetActualVolumeChain. We need the actual path as Line 11: given in the domain XML in order to properly update our metadata after Line 12: an active layer merge. We also want to use this function to return high Line 13: write watermark information for block volumes. This patch just converts > That is another way to do it. I chose this approach because it seemed like Can you explain when this new method of getting the write watermark is invoked? Do we poll now libvirt state while running live merge? Line 14: the format returned by _driveGetActualVolumeChain from a simple list to Line 15: a list of named tuples. Line 16: Line 17: Change-Id: I01d142a68903048accc95eb04d9930c326965db0 -- To view, visit http://gerrit.ovirt.org/31364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01d142a68903048accc95eb04d9930c326965db0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
