Nir Soffer has posted comments on this change.
Change subject: tool: Remove duplicate names
......................................................................
Patch Set 2:
> Each class in the configurators module must have a
> configurator subclass now:
> configurators->libvirt->configurator
> Is there a cleaner way?
> can we get somehow: libvirt() sanlock()
Since we need only one configurator instance, we can eliminate the classes and
use modules instead.
Example:
# libvirt.py
name = 'libvirt'
requires = frozenset(('certificates',))
services = ('vdsmd', 'supervdsmd', 'libvirtd')
def configure():
...
# configurator.py:
_CONFIGURATORS = dict((m.name, m) for m in (certificates, libvirt, sanlock))
If you have more complex code that need objects, you can implement the modules
methods using objects, the user of the module should not care about that.
I'm not going in this direction since I like small incremental changes. You are
invited to explore this direction if you like.
--
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
