Hello Douglas Schilling Landgraf, Yaniv Bronhaim, Dan Kenigsberg, Oved Ourfali,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/31777
to review the following change.
Change subject: configurator.py: call Node's delete() for file deletion on node.
......................................................................
configurator.py: call Node's delete() for file deletion on node.
delete() unpersists and shreds the file. the previous call to unpersist
after deleting a file is wrong.
Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49
Signed-off-by: Mooli Tayer <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/28821
Reviewed-by: Oved Ourfali <[email protected]>
Reviewed-by: Yaniv Bronhaim <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
Reviewed-by: Douglas Schilling Landgraf <[email protected]>
---
M lib/vdsm/tool/configurator.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/31777/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 4e755b2..9c9e33d 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -318,9 +318,10 @@
"""
delete a file if it exists.
"""
- utils.rmFile(content['path'])
if utils.isOvirtNode():
- NodeCfg().unpersist(content['path'])
+ NodeCfg().delete(content['path'])
+ else:
+ utils.rmFile(content['path'])
def _unprefixAndRemoveSection(self, path):
"""
--
To view, visit http://gerrit.ovirt.org/31777
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
