Nir Soffer has posted comments on this change. Change subject: tool: Make configurators more Pythonic ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py File lib/vdsm/tool/configurators/__init__.py: Line 55: # Services that must not run when this module is configured. The specified Line 56: # services will be stopped before this configurator is called, and will be Line 57: # started in reversed order when the configurator is done. Line 58: # May be overriden by subclass. Line 59: services = () > @property ? Ok, this is indeed safer. Line 60: Line 61: def validate(self): Line 62: return True Line 63: -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16092da09d6763a8222bc941bd7d1501a7bb3bff Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
