Nir Soffer has posted comments on this change. Change subject: Live Merge: Get volume chain for multiple drives ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/31366/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5535: if volChain: Line 5536: ret.append(volChain) Line 5537: else: Line 5538: raise LookupError("Failed to get volume chain for drive %s", Line 5539: drive.name) It is nice to fail with LookupError instead of returning empty results, but this make this API much less useful for getting info for multiple items. What if we want to get info for some drives, even if we one of the drives does not have any info? I think the previous version was better. Line 5540: return ret Line 5541: Line 5542: def _syncVolumeChain(self, drive): Line 5543: def getVolumeInfo(device, volumeID): -- To view, visit http://gerrit.ovirt.org/31366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d5a641b0814e3764c70bea8a6c1910a821adcc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
