Bala.FA has posted comments on this change. Change subject: gluster: Setup and verify ssl connection between nodes. ......................................................................
Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/18355/6/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 23: Line 24: from vdsm.define import doneCode Line 25: import supervdsm as svdsm Line 26: Line 27: _KEYFILE = '/root/.ssh/id_rsa' Why hard code root's key file? We would need to use vdsm.pem created by default. We should also check how to pass vdsm.pem file to geo-rep Line 28: Line 29: _SUCCESS = {'status': doneCode} Line 30: Line 31: GLUSTER_RPM_PACKAGES = ( -- To view, visit http://gerrit.ovirt.org/18355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6f040b1343998de4f8e28419c63e380240368db Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Better Saggi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
