Francesco Romani has posted comments on this change.
Change subject: vm: detect migration completed on recovery
......................................................................
Patch Set 2: Verified+1
Verified with 31669 and 31670.
Excerpt of the logs demonstrating the new behaviour.
*** rebooted mid-migration
clientIFinit::DEBUG::2014-08-22 16:44:34,963::clientIF::494::vds::(_recoverVm)
Trying to recover 56d1c657-dd76-4609-a207-c050699be5be
clientIFinit::DEBUG::2014-08-22 16:44:35,014::clientIF::403::vds::(createVm)
Total desktops after creation of 56d1c657-dd76-4609-a207-c050699be5be is 1
Thread-13::DEBUG::2014-08-22
16:44:35,014::vm::2264::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Start
Thread-13::DEBUG::2014-08-22
16:44:35,016::vm::2268::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::_ongoingCreations acquired
Thread-13::INFO::2014-08-22 16:44:35,018::vm::3277::vm.Vm::(_run)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::VM wrapper has started
Thread-13::DEBUG::2014-08-22
16:44:35,368::vm::2294::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::_ongoingCreations released
Thread-13::DEBUG::2014-08-22
16:44:35,370::vm::3999::vm.Vm::(_waitForUnderlyingMigration)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Waiting 21600 seconds for end of
migration
Thread-13::DEBUG::2014-08-22
16:44:41,612::vm::3995::vm.Vm::(_completeIncomingMigration)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::End of migration
Thread-15::DEBUG::2014-08-22 16:44:41,952::BindingXMLRPC::1134::vds::(wrapper)
return vmGetStats with {'status': {'message': 'Done', 'code': 0}, 'statsList':
[{'status': 'Up', 'displayInfo': [{'tlsPort': '-1', 'ipAddress':
'192.168.1.40', 'type': 'spice', 'port': u'5900'}], 'hash':
'-2847617701147730535', 'acpiEnable': 'true', 'guestFQDN': '', 'pid': '21515',
'displayIp': '192.168.1.40', 'displayPort': u'5900', 'session': 'Unknown',
'displaySecurePort': '-1', 'timeOffset': '-23', 'memUsage': '0', 'balloonInfo':
{'balloon_max': '4194304', 'balloon_target': '4194304', 'balloon_cur': '0',
'balloon_min': '2097152'}, 'clientIp': '', 'elapsedTime': '91', 'kvmEnable':
'true', 'network': {}, 'vmId': '56d1c657-dd76-4609-a207-c050699be5be',
'vmType': 'kvm', 'cpuUser': '0.00', 'disks': {u'vda': {'readLatency': '0',
'apparentsize': '7516192768', 'writeLatency': '0', 'imageID':
'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0', 'flushLatency': '0', 'truesize':
'7516192768'}, u'hdc': {'flushLatency'!
: '0', 'readLatency': '0', 'truesize': '0', 'apparentsize': '0',
'writeLatency': '0'}}, 'monitorResponse': '0', 'statsAge': '0.35', 'username':
'Unknown', 'displayType': 'qxl', 'cpuSys': '0.00', 'guestCPUCount': -1,
'appsList': [], 'guestIPs': ''}]}
*** down while migration completed:
clientIFinit::DEBUG::2014-08-22 16:51:17,829::clientIF::494::vds::(_recoverVm)
Trying to recover 56d1c657-dd76-4609-a207-c050699be5be
clientIFinit::DEBUG::2014-08-22 16:51:17,841::clientIF::403::vds::(createVm)
Total desktops after creation of 56d1c657-dd76-4609-a207-c050699be5be is 1
Thread-13::DEBUG::2014-08-22
16:51:17,841::vm::2264::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Start
Thread-13::DEBUG::2014-08-22
16:51:17,842::vm::2268::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::_ongoingCreations acquired
Thread-13::INFO::2014-08-22 16:51:17,843::vm::3277::vm.Vm::(_run)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::VM wrapper has started
Thread-13::DEBUG::2014-08-22
16:51:19,894::vm::2294::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::_ongoingCreations released
Thread-13::INFO::2014-08-22
16:51:19,898::vm::3971::vm.Vm::(_completeIncomingMigration)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::migration completed while
recovering!
Thread-13::DEBUG::2014-08-22
16:51:19,966::vm::3995::vm.Vm::(_completeIncomingMigration)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::End of migration
Thread-15::DEBUG::2014-08-22 16:51:23,263::BindingXMLRPC::1134::vds::(wrapper)
return vmGetStats with {'status': {'message': 'Done', 'code': 0}, 'statsList':
[{'status': 'Up', 'displayInfo': [{'tlsPort': '-1', 'ipAddress':
'192.168.1.40', 'type': 'spice', 'port': u'5900'}], 'hash':
'7299066554641300571', 'acpiEnable': 'true', 'guestFQDN': '', 'pid': '22431',
'displayIp': '192.168.1.40', 'displayPort': u'5900', 'session': 'Unknown',
'displaySecurePort': '-1', 'timeOffset': '0', 'memUsage': '0', 'balloonInfo':
{'balloon_max': '4194304', 'balloon_target': '4194304', 'balloon_cur': '0',
'balloon_min': '2097152'}, 'clientIp': '', 'elapsedTime': '136', 'kvmEnable':
'true', 'network': {}, 'vmId': '56d1c657-dd76-4609-a207-c050699be5be',
'vmType': 'kvm', 'cpuUser': '0.00', 'disks': {u'vda': {'readLatency': '0',
'apparentsize': '7516192768', 'writeLatency': '0', 'imageID':
'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0', 'flushLatency': '0', 'truesize':
'7516192768'}, u'hdc': {'flushLatency': !
'0', 'readLatency': '0', 'truesize': '0', 'apparentsize': '0', 'writeLatency':
'0'}}, 'monitorResponse': '0', 'statsAge': '1.30', 'username': 'Unknown',
'displayType': 'qxl', 'cpuSys': '0.00', 'guestCPUCount': -1, 'appsList': [],
'guestIPs': ''}]}
Non-regression: verified basic migration (destination) and recovery flows, see
comments to changes 31669 and 31670
--
To view, visit http://gerrit.ovirt.org/31671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451c2a940693842e9bf7c63ccc117e75026bb11b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
