Francesco Romani has posted comments on this change. Change subject: vdsm: add tests for hostdev mapper ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31766/1/tests/hostdevTests.py File tests/hostdevTests.py: Line 25: from vdsm import libvirtconnection Line 26: from monkeypatch import MonkeyPatch Line 27: Line 28: Line 29: class ifMock(object): > Thanks, according to the article 'stub' is the correct term as far as I und there is also alread clientIFFake inside vmTests.py which may fit your needs. I'll need to spawn off these fakes from vmTests.py in a reusable module... Line 30: Line 31: def __init__(self): Line 32: self.vmContainer = {} Line 33: Line 47: Line 48: # unfortunately, in real environment these are the most problematic calls Line 49: # but in order to test them, we would put host in danger of removing Line 50: # device needed to run properly (such as nic) Line 51: def dettach(self): > this is mistake on libvirt's side: the calls really are called dettach and No problem to me. Just add a one-line reminder in the code :) Line 52: pass Line 53: Line 54: def reAttach(self): Line 55: pass -- To view, visit http://gerrit.ovirt.org/31766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ba986c77ec710f6becd0244e86d27ec2023e27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
