Dima Kuznetsov has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31501/2/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 72: if _oopImpl == IOPROC: Line 73: with _procPoolLock: Line 74: keys = sorted(_procPool, key=_procPool.get) Line 75: for k in keys: Line 76: if (time.time() - _procPool[k][0]) > DEF_IOPROC_TIMEOUT: Maybe worth adding "and k != clientName" so you don't delete the proc you're about to use? Line 77: del _procPool[k] Line 78: else: Line 79: break Line 80: -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
